Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): emit expand event when expanded because of menu click #1897

Merged
merged 2 commits into from
Oct 14, 2019
Merged

fix(sidebar): emit expand event when expanded because of menu click #1897

merged 2 commits into from
Oct 14, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Aug 9, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1432

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #1897 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1897      +/-   ##
==========================================
+ Coverage   84.19%   84.23%   +0.03%     
==========================================
  Files         235      235              
  Lines        7903     7903              
  Branches      693      693              
==========================================
+ Hits         6654     6657       +3     
+ Misses       1046     1042       -4     
- Partials      203      204       +1
Impacted Files Coverage Δ
...work/theme/components/sidebar/sidebar.component.ts 56.33% <100%> (+1.4%) ⬆️
...mework/theme/components/sidebar/sidebar.service.ts 88% <0%> (+4%) ⬆️

@yggg yggg changed the title fix(sidebar): emit expend event when expanded because of menu click fix(sidebar): emit expand event when expanded because of menu click Aug 28, 2019
@yggg yggg marked this pull request as ready for review October 8, 2019 16:25
@yggg yggg requested a review from nnixaa October 8, 2019 16:25
@yggg yggg merged commit a07487d into akveo:master Oct 14, 2019
@yggg yggg deleted the fix/sidebar-emit-event-when-expanded-after-menu-click branch October 14, 2019 08:52
@ykamchi
Copy link

ykamchi commented Nov 21, 2020

Hi,

Is this bug fixed on version 5.0.0? I still do not get notifications from the service on:

  1. this.sidebarService.onExpand().subscribe( ....
  2. this.sidebarService.onCollapse().subscribe( ....
  3. this.sidebarService.compact().subscribe( ....

Thanks,
Yohay

@Aaron-Linkforce
Copy link

Aaron-Linkforce commented Dec 18, 2020

Also reporting on 5.0 - onToggle returns a notification, however onExpand doesn't return anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NbSidebarService onExpand() don't get event when sidebar is expanded by click on nb-menu item with submenu
4 participants