Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree grid): assert node children is defined before spreading #1898

Merged
merged 3 commits into from
Aug 29, 2019
Merged

fix(tree grid): assert node children is defined before spreading #1898

merged 3 commits into from
Aug 29, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Aug 9, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Spread on undefined throws in ES2015. Closes #1849

@yggg yggg requested a review from nnixaa August 29, 2019 08:33
@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #1898 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
- Coverage   84.08%   84.07%   -0.02%     
==========================================
  Files         234      234              
  Lines        7723     7724       +1     
  Branches      679      680       +1     
==========================================
  Hits         6494     6494              
- Misses       1031     1032       +1     
  Partials      198      198
Impacted Files Coverage Δ
...ponents/tree-grid/data-source/tree-grid.service.ts 60% <0%> (-2.5%) ⬇️

@yggg yggg merged commit 26ad5d2 into akveo:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treegrid Problem
2 participants