Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(window): add window buttons configuration #2762

Merged
merged 16 commits into from
Jun 16, 2021
Merged

feat(window): add window buttons configuration #2762

merged 16 commits into from
Jun 16, 2021

Conversation

andreipadolin
Copy link
Contributor

@andreipadolin andreipadolin commented Jun 11, 2021 •
edited

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes #2382
Related to #2642

Screenshot 2021-06-14 at 15 17 32

@andreipadolin andreipadolin requested a review from yggg June 11, 2021 06:01
andreipadolin and others added 15 commits June 14, 2021 15:15
@andreipadolin
refactor(window): buttons config
6c7ae72
@andreipadolin
test(window): added test for buttons config
0ad26c6
@yggg
Merge branch 'master' into bugfix-2382
f8d2819
@yggg
style: revert unnecessary changes
753c02e
@yggg
style: group Angular imports together
39dab1c
@yggg
refactor: remove unused import
1d15985
@yggg
fix(window options): put back required import
7a0e36b
@yggg
docs(window service): rephrase control buttons example text
97d2a83
@yggg
docs(window options): fix type in button property description
a8a5866 
And remove code example as property docs doesn't render it correctly.
@yggg
docs(window controls): simplify example
5ab857c
@yggg
refactor(window config): rename expandCollapse to fullScreen
1307760
@yggg
feat(window config): do not maximize window if maximize button disabled
ad5e7ec
@yggg
docs(window controls): use renamed property in the example
7b1205d
@yggg
docs(window controls): remove styles from previous example version
08facfb
@yggg
style(window spec): revert unnecessary change
6281f8a
@yggg yggg changed the title feat(window): added window control buttons configuration feat(window): add window buttons configuration Jun 16, 2021
@yggg yggg merged commit 9dcd40e into akveo:master Jun 16, 2021
@andreipadolin andreipadolin deleted the bugfix-2382 branch June 16, 2021 14:55
@yggg yggg mentioned this pull request Nov 30, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yggg yggg yggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Button Proporties to NbWindowConfig
2 participants
@andreipadolin @yggg