Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(timepicker): add localization config #2719

Merged
merged 4 commits into from
Jun 15, 2021

Conversation

unumtresocto
Copy link
Contributor

@unumtresocto unumtresocto commented Apr 20, 2021

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #2632

@unumtresocto unumtresocto requested a review from yggg April 20, 2021 14:04
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #2719 (f17efc2) into master (002adc2) will decrease coverage by 6.78%.
The diff coverage is 75.47%.

❗ Current head f17efc2 differs from pull request most recent head fd01cef. Consider uploading reports for the commit fd01cef to get more accurate results

@@            Coverage Diff             @@
##           master    #2719      +/-   ##
==========================================
- Coverage   84.57%   77.79%   -6.79%     
==========================================
  Files         235      262      +27     
  Lines        8059     8231     +172     
  Branches      710      896     +186     
==========================================
- Hits         6816     6403     -413     
- Misses       1023     1553     +530     
- Partials      220      275      +55     
Impacted Files Coverage Δ
src/framework/auth/components/auth.component.ts 28.57% <0.00%> (-15.88%) ⬇️
...framework/auth/strategies/auth-strategy-options.ts 100.00% <ø> (ø)
.../auth/strategies/oauth2/oauth2-strategy.options.ts 100.00% <ø> (ø)
...ramework/auth/strategies/oauth2/oauth2-strategy.ts 83.57% <ø> (-1.10%) ⬇️
...work/auth/strategies/password/password-strategy.ts 97.59% <ø> (-0.24%) ⬇️
...ponents/accordion/accordion-item-body.component.ts 46.15% <0.00%> (-12.67%) ⬇️
...nents/accordion/accordion-item-header.component.ts 40.00% <0.00%> (-8.28%) ⬇️
...e/components/accordion/accordion-item.component.ts 28.57% <0.00%> (-9.73%) ⬇️
.../theme/components/accordion/accordion.component.ts 41.66% <ø> (-11.67%) ⬇️
...eme/components/calendar-kit/calendar-kit.module.ts 100.00% <ø> (ø)
... and 322 more

@yggg yggg added this to the 8.0.0 milestone Apr 22, 2021
@yggg yggg changed the title fix(timepicker): add localization provider for timepicker feat(timepicker): add localization config Jun 15, 2021
@yggg yggg merged commit b9c77ce into akveo:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nb-date-timepicker component: Timepicker part of the component doesn't adhere to the set locale
2 participants