You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using the nb-date-timepicker, the timepicker part of the component doesn't adhere to the set locale. The "now" button and the abbreviations for "hour" ("Hr"), "minute" ("Min") and "second" ("Sec") are always in English.
The datepicker part works fine.
Expected behavior:
The nb-date-timepicker component adheres to the set locale, both the datepicker part and the timepicker part of the component.
Steps to reproduce:
Set the locale to any other locale than 'en' (English).
Use the nb-date-timepicker component on any page.
When opened, the datepicker part uses the correct locale, but the timepicker part doesn't.
It appears that the heading labels for "Hr", "Min", "Sec" are hardcoded at lines 149 - 151 in file: /src/framework/theme/components/timepickers/timepicker.component.ts
I'm having difficulty setting up my local environment to test making changes, but I hope this information helps anybody else looking to resolve this issue!
It appears that the heading labels for "Hr", "Min", "Sec" are hardcoded at lines 149 - 151 in file: /src/framework/theme/components/timepickers/timepicker.component.ts
I'm having difficulty setting up my local environment to test making changes, but I hope this information helps anybody else looking to resolve this issue!
I figured they was hardcoded values somewhere, I just didn't have time to search for them. They doesn't look too hard to make configurable, though, since they're already inputs in the Timepicker component.
If I get the time to fix them, I will do so and make a PR so we can get them configurable in a future version of Nebular :)
Issue type
I'm submitting a ... (check one with "x")
Issue description
Current behavior:
When using the nb-date-timepicker, the timepicker part of the component doesn't adhere to the set locale. The "now" button and the abbreviations for "hour" ("Hr"), "minute" ("Min") and "second" ("Sec") are always in English.
The datepicker part works fine.
Expected behavior:
The nb-date-timepicker component adheres to the set locale, both the datepicker part and the timepicker part of the component.
Steps to reproduce:
Related code:
See this stackblitz
Other information:
npm, node, OS, Browser
Angular, Nebular
The text was updated successfully, but these errors were encountered: