Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmartTable Custom Action Problem for displaying Icons #5821

Open
1 of 3 tasks
Whisper40 opened this issue Jan 9, 2021 · 1 comment
Open
1 of 3 tasks

SmartTable Custom Action Problem for displaying Icons #5821

Whisper40 opened this issue Jan 9, 2021 · 1 comment

Comments

@Whisper40
Copy link

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request
  • question about the decisions made in the repository

Issue description

Current behavior:

If you create custom action other than edit,remove,add. And if you add an icon, you will see that there is a problem of display. The icon is not in a row, but between rows.

Expected behavior:
The icon has to be in a row

Steps to reproduce:
Use smarttable, create custom action, add an icon to this action. Look the icon

image

actions: {
      add: false,
      edit: false,
      delete: false,
      columnTitle: "Actions",
      custom: [{ name: 'ourCustomAction', title: '<i class="ion-edit" title="YourAction"></i>' }],
      position: 'right',
    },     
    columns: {
      id: {
        title: 'ID',
        type: 'number',
        width: '7%'
      },
....
...

Other information:

Version : 2 Nov 2020

@Whisper40
Copy link
Author

Whisper40 commented Jan 9, 2021

If others need to solve it very fast :
In style.scss

.nb-theme-default ng2-smart-table .ng2-smart-actions  {
  height: revert;
}
.nb-theme-dark ng2-smart-table .ng2-smart-actions  {
  height: revert;
}
.nb-theme-cosmic ng2-smart-table .ng2-smart-actions  {
  height: revert;
}
.nb-theme-corporate ng2-smart-table .ng2-smart-actions  {
  height: revert;
}

[EDIT] Other solution, choose one ! -> akveo/ng2-smart-table#1197

Why ?
image

A property with height: 1px; is causing the problem

Let me know if a good fix is found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant