Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2417] project_update API POST fails when photo is None #2418

Merged
merged 1 commit into from
Nov 8, 2016

Conversation

punchagan
Copy link
Contributor

@punchagan punchagan commented Oct 21, 2016

  • Test plan | Unit test | Integration test
  • Copyright header
  • Code formatting
  • Documentation
  • Change log entry

This bug was introduced in 1aa6050

Any API POST where 'photo' field is None would fail, but I don't yet know what exact user action triggered this report: http://sentry.support.akvo-ops.org/rsr/live/group/1017/

Closes #2417

@punchagan
Copy link
Contributor Author

Test plan

  • Pick any project with a photo for the project
  • Go to Section 1 of the project editor
  • Try to delete the photo, and it should work.

@punchagan punchagan force-pushed the #2417-photo-none branch 2 times, most recently from 4f36e79 to d10b8ab Compare October 27, 2016 05:41
@punchagan punchagan added this to the 3.18 Vilnius milestone Nov 8, 2016
@zzgvh zzgvh merged commit aac03a6 into develop Nov 8, 2016
@zzgvh zzgvh removed the Needs Review label Nov 8, 2016
@punchagan punchagan deleted the #2417-photo-none branch November 23, 2016 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants