[#2494] Switch to DB queries to get allow_edit_projects #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzgvh
approved these changes
Jan 2, 2017
| Partnership.objects.create(project=project, organisation=org) | ||
| self.c = Client(HTTP_HOST=settings.RSR_DOMAIN) | ||
|
|
||
| def tearDown(self): |
There was a problem hiding this comment.
Nitpick: should the Groups be deleted here too?
There was a problem hiding this comment.
check_auth_groups actually checks if groups exist before trying to create them. So, it doesn't really matter, but I guess for consistency, it's better to delete them. I'll push a fix.
To get the list of projects where a user has `change` permissions, use DB queries instead of a loop wrapping DB queries to make the response much faster. This fixes timeouts for users who are not rsr admins but have change permissions for a lot of projects. Closes #2494
punchagan
force-pushed
the
#2494-fix-api-key-permissions
branch
from
341ac13
to
40849ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get the list of projects where a user has
changepermissions, use DBqueries instead of a loop wrapping DB queries to make the response much faster.
This fixes timeouts for users who are not rsr admins but have change
permissions for a lot of projects.
Closes #2494