[#2356] Enable publish & add project buttons only if user has perms #2601
Conversation
punchagan
force-pushed
the
issue/2356-publish-button
branch
from
3f47117
to
766dbb2
Compare
punchagan
force-pushed
the
issue/2356-publish-button
branch
from
766dbb2
to
a031286
Compare
The Publish button can be enabled/disabled in setPageCompletionPercentage(). Only set/remove disabled in setPageCompletionPercentage() if the user can publish the project.
Superusers should be able to create/publish projects no matter what.
akvo/rsr/models/user.py
Outdated
| :return: Boolean to indicate whether the user has a reportable organisation | ||
| """ | ||
| if self.is_superuser or self.is_admin: | ||
| if self.is_superuser: |
There was a problem hiding this comment.
Let's keep god-mode. Not sure about self.is_admin, I think this is Akvo staff only and if so it might apply to them too?
There was a problem hiding this comment.
self.has_perm automatically gives all permissions to any user who is a superuser. Also, if a user is_admin they have the rsr.add_project permissions given to them in our permission config. So, I don't think this special case is required.
There was a problem hiding this comment.
When adding a new project, approved employments of a user are used to determine which organisation to add the project to. Having an admin/super user without any employments trying to add a new project will be a problem, if we have this special case.
There was a problem hiding this comment.
Ah...OK you have to have an employment then I guess.
This reverts commit 3165f3a.
Closes #2356
Closes #2362