RSR Release v3.40.2 (Hot-fix) #3409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
punchagan
commented
Nov 8, 2018
punchagan
commented
- Test plan | Unit test | Integration test
- Copyright header
- Code formatting
- Documentation
- Change log entry
The extra_context is added only to template rendering for views. When rendering the templates for inclusion_tags, the extra variables defined using `extra_context` don't get passed. This causes the map URLs in the projects map widget to show a warning about missing Google Maps API key. This commit fixed the problem, that was assumed to have been fixed with 4530881.
…i-key [#3368] Fix missing gmaps_api_key in inclusion_tags templates
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.