Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Stored XSS #5

Closed
soulfoodisgood opened this issue Feb 3, 2021 · 4 comments
Closed

Multiple Stored XSS #5

soulfoodisgood opened this issue Feb 3, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@soulfoodisgood
Copy link

soulfoodisgood commented Feb 3, 2021

[Description]
Multiple XSS payloads are available for znote. It leads to attacker's javascript execution

[Reproduce]
You can try with copy paste the payloads below:
1.

<svg>
<svg onload=alert(1)>

<iframe src=x onload=alert(1)>

截圖 2021-02-03 下午9 57 16

@alagrede
Copy link
Owner

alagrede commented Feb 3, 2021

Hello @soulfoodisgood,
First of all, thank you for your report.
I'm trying to define the relevance of this issue.
Executing HTML/JS in the viewer it's originally a developer feature. It is the owner's responsibility to check the content of these notes.
I could probably prevent javascript execution without affecting HTML functionality and/or add a flag to manually allow javascript to run in files.
Thanks

@alagrede alagrede added the enhancement New feature or request label Feb 3, 2021
@soulfoodisgood
Copy link
Author

soulfoodisgood commented Feb 4, 2021

Please check https://medium.com/bugbountywriteup/remote-code-execution-through-cross-site-scripting-in-electron-f3b891ad637
XSS is dangerous for electron apps because once nodeIntegration set as true or it can be bypassed to get "require" available, it leads to remote code execution .

@alagrede
Copy link
Owner

alagrede commented Feb 4, 2021

Ok, for me. Thank you for drawing my attention to this point. I will provide a solution very soon.

@alagrede alagrede self-assigned this Feb 4, 2021
@alagrede alagrede added this to the 0.5.3 milestone Feb 4, 2021
@alagrede
Copy link
Owner

alagrede commented Feb 4, 2021

Fix in 0.5.3. It's coming on Windows/Mac App stores.

@alagrede alagrede closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants