Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issue with js-yaml (dependency of mocha) #182

Closed
meszaros-lajos-gyorgy opened this issue Apr 16, 2019 · 4 comments
Closed

Security issue with js-yaml (dependency of mocha) #182

meszaros-lajos-gyorgy opened this issue Apr 16, 2019 · 4 comments

Comments

@meszaros-lajos-gyorgy
Copy link

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ Code Injection                                               │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ js-yaml                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=3.13.1                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ reload [dev]                                                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ reload > mocha > js-yaml                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/813                       │
└───────────────┴──────────────────────────────────────────────────────────────┘

Mocha is currently hardcoded to version 6.1.0, which should be changed to a range version in the long run.

Mocha is already working on a fix (mochajs/mocha#3876), so renovate should be held back until the next release.

@meszaros-lajos-gyorgy
Copy link
Author

A fix is out in version 6.1.4: https://github.com/mochajs/mocha/releases/tag/v6.1.4

@cekvenich
Copy link

cekvenich commented Apr 20, 2019

Does mocha need to be dependency? Maybe it is just dev dependency.

@alallier
Copy link
Owner

alallier commented Apr 20, 2019

@cekvenich you make a good point that's an error on my behalf mocha should be in the dev dependencies. I'll open an issue (#186)!

Thanks @meszaros-lajos-gyorgy I'll see if I can get these things merged tomorrow

@alallier
Copy link
Owner

Closed by #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants