Recent Development #435
Merged
Recent Development #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes issue #428
This commit adds a scraper `scrape_understat.py` that aims to scrape the goal time and goal scorer for each match from the '15-'16 season. It also pulls in the substitution information.
This commit clears the docstring of the `parse_match` function to add information about the exact structure of the goals and subs data. It also adds the complete datafiles for the seasons 16-17, 17-18, 18-19, 19-20, and 20-21. Also adds beautifulsoup dependency in the requirement.txt file.
…o feature/pre-commit
- Added the 5-2-3 formation to the FORMATIONS list - Removed the ACTIVE_PER_POSITION variable as it's not used anywhere Resolves: #222
The choices for the `season` CLI argument are now based on the keys of the `base_url` dictionary. This makes it easier to add/remove seasons as only one variable needs to be changed.
Now raise KeyError for wrong season value and also raise Error if no response is received. Furthermore, used `black` formatter to add strict formatting to the code. This led to splitting a couple of strings to two lines with f-strings.
Add 5-2-3 formation
…tion-docs Feature/349/convention docs
Add isort and pre-commit config
This mainly adds the isort changes that happen in the imports of most of the files.
to avoid circular import
rather than using repo secret
I had been using `find` function in finding the rows that corresponded to a substitution which led just recording one substitution if more than one substitutions were being made at the same time. Changed the call to `find_all` and looping over all the rows to now record all the substitutions instead. As can be seen in the data files, this has led to the inclusion of several instances where we were missing 1 or even 2 other substitutions.
Add scraper for understat.com (Fixes #430)
update version number ready for merging into `main`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent Development
This pull request is a staging area for the changes and improvements that will be added to AIrsenal in its next release, which are described below. If you would like to try these changes before release you can reinstall AIrsenal from our
developbranch - there are instructions in the readme (but note that there may be bugs or undocumented changes).New Features
Enhancements
Bug Fixes
When this PR is ready to merge:
Before merging: Update the AIrsenal package version in
airsenal/__init__.py. If newfeatures have been added increment the middle number, e.g. 1.1.1 -> 1.2.0,
or if bug fixes only change the last number, e.g. 1.1.1 -> 1.1.2.
After merging: Create a new release
tagged with the new version number. The release text should include the changes above.