Minor fixes + docstrings #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially adding docstrings and a common helper function for checking compatibility of vector dimensions
…where appropriate
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
- Coverage 70.92% 70.81% -0.11%
==========================================
Files 19 19
Lines 1410 1398 -12
==========================================
- Hits 1000 990 -10
+ Misses 410 408 -2
Continue to review full report at Codecov.
|
ablaom
reviewed
Jul 22, 2019
ablaom
reviewed
Jul 22, 2019
ablaom
reviewed
Jul 22, 2019
ablaom
requested changes
Jul 22, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly inconsequential and the fixes are usually minor happening as I was reading the code:
@with_kwmacro where relevant to automatically get structs constructors with keyword arguments(e[i] for i in ...)instead of[e[i] for i in ...])I don't think it requires a lot of code review but given there are a lot of small changes I thought it was better to have another pair of eyes quickly have a look in case.
PS: ignore the first bunch of erroneous commits where the tests were not running on my machine due to Julia 1.3 and I basically had to push things to see what was wrong.