Move plt import inside functions that use it #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm interested in using this package in a production system.
Overall, it is very well structured and easy to use. There is one tiny issue:
matplotlib.pyplot
has import-time side effects. There is a lot to say here, but the upshot is that you need to ensure you have all matplotlib backend 100% configured before you importpyplot
, otherwise it can lead to unexpected results.The
matplotlib
library itself doesn't have this issue, so it's safe to import that at the top-level, butpyplot
is another story. A reasonable workaround is to simply delay the import ofpyplot
until you actually need it. That gives any external system a change to import all of it's main libraries and then do any user-specific backend customization before any plots are generated.This is all to say: I moved the
import matplotlib.pyplot as plt
imports into the functions that used them.Let me know what you think / if there are any issues that you foresee in making this change.