-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reporting ptype outputs via schemas #62
Comments
I have made some progress on this. Please see #64. |
@tahaceritli If you add new issues to the Project (drop-down menu on the right) they’ll appear in the kanban board! |
Thanks for pointing these out.
Let me know what you think. I will try to sort out item 6 and push my changes in the meantime. |
Minor comment regarding no. 5: This reminds me of an earlier discussion (original message in #11) that this fits in the scikit-learn "transformer" idea: you fit the schema with, say, |
Some issues to address:
Column
and components of aSchema
as_normal
: one intest_ptype
and two inPtype
show_results_df
no longer used (have it return a dataframe with a single row?)transform_schema
take adf
argument?as_normal
is discarded intransform_schema
features
toColumn
all_posteriors
Ptype.column
arff_type
inference toColumn
constructorDone/dropped:
value of– method no longer neededas_normal
is discarded inget_final_df
update_dtypes
suggests a pure function, but mutates its argumentstrip-notebook-output
in.gitattributes
seaborn==0.9.0
so it doesn’t issue a warning aboutdistplot
@GjjvdBurg proposes the following design which could be further modified if needed:
The text was updated successfully, but these errors were encountered: