Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated version not detected #23

Open
dyve opened this issue Jan 3, 2019 · 9 comments
Open

Updated version not detected #23

dyve opened this issue Jan 3, 2019 · 9 comments
Labels

Comments

@dyve
Copy link

dyve commented Jan 3, 2019

I notice that pur will not detect updates for black (https://github.com/ambv/black).

Reproduction of error:

  • make new virtualenv
  • pip install pur
  • make new requirements.txt
  • add black==18.6b4 to requirements.txt
  • pip install -r requirements.txt
  • confirm black==18.6b4 in output of pip freeze
  • run pur -f -r requirements.txt
  • pur will not update black version, confirm black==18.6b4 in requirements.txt
  • run pip install -U black
  • pip will find newer black version, at the time of writing black==18.9b0
@eLBati
Copy link

eLBati commented Jan 9, 2019

I noticed a similar behaviour with odoo modules.
I have a requirements.txt file with several lines, for example odoo12-addon-l10n-it-fatturapa==12.0.1.0.0.99.dev13
Even if a new version of the module is released https://pypi.org/project/odoo12-addon-l10n-it-fatturapa/#history
when I run pur -r requirements.txt its version is not updated

@alanhamlett
Copy link
Owner

By default, pur does not update packages to pre-release versions for stability reasons. To enable updates to pre-release versions, use --pre * like this:

pur -r requirements.txt --pre "*"

@eLBati
Copy link

eLBati commented Jan 23, 2019

@alanhamlett it does not work. Please create a requirements.tx with the following line
odoo12-addon-l10n-it-fatturapa-out==12.0.1.0.1.99.dev13
and run pur -r requirements.txt --pre "*"

@alanhamlett alanhamlett reopened this Jan 23, 2019
@alanhamlett
Copy link
Owner

This call to Pip is returning an empty set of candidates for upgrading:

all_candidates = finder.find_all_candidates(req.name)

I've updated pip to the latest version (19.1.dev0) and it's still returning an empty set. The problem could be in how we setup PackageFinder:

finder = PackageFinder(

@lancelote
Copy link
Contributor

$ pur -r requirements.txt --pre "*"
Updated odoo12-addon-l10n-it-fatturapa-out: 12.0.1.0.1.99.dev13 -> 12.0.1.0.2.99.dev2

seems to be correct. @eLBati Do you get the different result?

P.S. odoo12-addon-l10n-it-fatturapa and odoo12-addon-l10n-it-fatturapa-out are two different packages.

@eLBati
Copy link

eLBati commented Jan 28, 2019

@lancelote

$ cat requirements.txt 
odoo12-addon-l10n-it-fatturapa-out==12.0.1.0.1.99.dev13
$ pur -r requirements.txt --pre "*"
All requirements up-to-date.
$ cat requirements.txt 
odoo12-addon-l10n-it-fatturapa-out==12.0.1.0.1.99.dev13
$ pur --version
pur, version 5.2.1
$ pip --version
pip 19.0.1 from /usr/local/lib/python2.7/dist-packages/pip (python 2.7)

@lancelote
Copy link
Contributor

lancelote commented Jan 28, 2019

@eLBati Thanks, the difference was in Python version, it works with 3.7 but fails with 2.7.

Update after some debugging: maybe I am missing something again but odoo12-addon-l10n-it-fatturapa-out requires Python 3.

@lancelote
Copy link
Contributor

@alanhamlett I guess the issue can be closed. odoo12-addon-l10n-it-fatturapa-out requires Python 3 and no available updates for Python 2 is expected.

@alanhamlett
Copy link
Owner

Let's leave this open, since it's not related to that single package and we should support this requirement spec in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants