Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate facade #33

Closed
hackel opened this issue Jun 7, 2016 · 1 comment
Closed

Remove duplicate facade #33

hackel opened this issue Jun 7, 2016 · 1 comment

Comments

@hackel
Copy link

hackel commented Jun 7, 2016

src/Alaouy/Youtube/YoutubeFacades.php is identical to src/Alaouy/Youtube/Facades/Youtube.php. In addition, the former is improperly named and namespaced. This results in composer complaining:

Warning: Ambiguous class resolution, "Alaouy\Youtube\Facades\Youtube" was found in both "vendor/alaouy/youtube/src/Alaouy/Youtube/YoutubeFacades.php" and "vendor/alaouy/youtube/src/Alaouy/Youtube/Facades/Youtube.php", the first will be used.

I have no idea what YoutubeFacades.php is/was used for, but it clearly should be removed!
@alaouy
Copy link
Owner

alaouy commented Jun 11, 2016

@hackel Thanks for this!

@alaouy alaouy closed this as completed Jun 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hackel @alaouy