Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommonJS or AMD dependencies can cause optimization bailouts #70

Open
malcomm opened this issue Sep 15, 2020 · 2 comments
Open

CommonJS or AMD dependencies can cause optimization bailouts #70

malcomm opened this issue Sep 15, 2020 · 2 comments

Comments

@malcomm
Copy link

malcomm commented Sep 15, 2020

Angular 10 is now throwing this warning:

WARNING in /someproject/node_modules/ngx-papaparse/__ivy_ngcc__/fesm2015/ngx-papaparse.js depends on 'papaparse/papaparse.min.js'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Just wanted to put this on your radar.

See: https://web.dev/commonjs-larger-bundles/
@alberthaff
Copy link
Owner

Hi.

Unfortunately, i can't really do anything about that for now.

The problem is with the underlying library. For more information, see https://alberthaff.dk/projects/ngx-papaparse/docs/v5/installation/angular-10-or-later

@jweisman
Copy link

Looks like this is being worked on:
mholt/PapaParse#875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jweisman @alberthaff @malcomm