-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share benchmarks #2
Comments
Yes, I've been thinking about doing this. I don't think URL hashes will be feasible, the code may be too long to share. Gists might be reasonable, I haven't figured out exactly how I'd implement this yet. |
You can look at the documentation : It should do what you want 👍 |
http://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url-in-different-browsers I think 2000chars is good enough for many micro benchmarks. |
There you go : |
@sonnyp Agreed, however there's the issue of "shareability", e.g. is it okay to share a link that's ~200 characters long? @nobe4 Thanks for the code snippet. The API is very simple and allows for anonymous posts, which is great. Also, the raw gist allows cross-origin requests, which allows us to retrieve the content via AJAX. The issue of how to integrate this into stool is still an issue. There needs to be a specific input format, and an import from gist option. |
Do you want another snippet implementing the other side ? |
I don't think it's a matter of implementation - it's more of just deciding how we're going to implement it. |
I thinks, as we can separate files in gist, we should use it. |
👍 that's what I was thinking as well |
Btw I tried to develop some kind of wrapper around benchmark.js, do you think it can be usefull ? |
I think the Benchmark API is simple enough, and the code is not a huge mess (yet). |
You got it :) |
Okay, implemented in 917a904 Thanks all for the great suggestions! |
Would be awesome to use a url hash with tests code to share benchmarks.
Also stool could rely on 3rd party services such as gists for saving/sharing.
The text was updated successfully, but these errors were encountered: