using the latest cookiecutter to make maintenance easier #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiki-tempula
changed the title
orbeckst
requested changes
Mar 25, 2024
LICENSE
Outdated
|
|
||
| Redistribution and use in source and binary forms, with or without | ||
| modification, are permitted provided that the following conditions are met: | ||
| Copyright 2024, alchemtest developers |
There was a problem hiding this comment.
Suggested change
| Copyright 2024, alchemtest developers | |
| Copyright (c) 2017-2024, alchemtest developers |
LICENSE
Outdated
| @@ -1,28 +1,21 @@ | |||
| Copyright (c) 2017, alchemtest developers | |||
There was a problem hiding this comment.
Keep the original license file. I don't want to have to think like a lawyer and figure out if the old and the new one are equivalent. Just keep the old file verbatim.
| # omit the versioneer-installed _version.py | ||
| src/alchemtest/_version.py | ||
| alchemtest/_version.py |
There was a problem hiding this comment.
Do we still have a file _version.py?
There was a problem hiding this comment.
It is automatically generated by git versioneer when you pip install it. Looks like
__version__ = "0.10.0.dev0"
.github/workflows/CI.yaml
Outdated
Comment on lines
43
to
48
| - name: Additional info about the build | ||
| shell: bash | ||
| run: | | ||
| uname -a | ||
| df -h | ||
| ulimit -a |
There was a problem hiding this comment.
We can probably delete this section — I don't think I ever cared about this info.
docs/conf.py
Outdated
|
|
||
| # -- General configuration ------------------------------------------------ | ||
| project = 'alchemtest' | ||
| copyright = ("2024, David Dotson, Zhiyi Wu. Project structure based on the " |
There was a problem hiding this comment.
2017-2024 and include all authors or "The Alchemtest Authors"
docs/conf.py
Outdated
| project = 'alchemtest' | ||
| copyright = ("2024, David Dotson, Zhiyi Wu. Project structure based on the " | ||
| "Computational Molecular Science Python Cookiecutter version 1.1") | ||
| author = 'David Dotson, Zhiyi Wu' |
docs/conf.py
Outdated
| author = 'David Dotson, Zhiyi Wu' | ||
|
|
||
| # The short X.Y version | ||
| version = '' |
docs/conf.py
Outdated
| # The short X.Y version | ||
| version = '' | ||
| # The full version, including alpha/beta/rc tags | ||
| release = '' |
Co-authored-by: Oliver Beckstein <orbeckst@gmail.com>
orbeckst
approved these changes
Mar 30, 2024
This was referenced Mar 30, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For easier future maintenance, I think it would be good for this repo to adopt the MOLSSI cookiecutter.
Then we could easily pull fix from there.
This PR also fixed RTD (See the build for this here https://alchemtest--93.org.readthedocs.build/en/93/)
Also fixes #92
Tested in https://github.com/alchemistry/alchemlyb/actions/runs/8409355524/job/23026883761?pr=351
The versioner is gone in this PR.