Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.2.0 release #346

Merged
merged 7 commits into from
Apr 6, 2024
Merged

2.2.0 release #346

merged 7 commits into from
Apr 6, 2024

Conversation

xiki-tempula
Copy link
Collaborator

I have uploaded to pip and test that it works fine.

@xiki-tempula xiki-tempula linked an issue Jan 8, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.82%. Comparing base (4e150f8) to head (9fdb2b4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files          28       28           
  Lines        1875     1875           
  Branches      405      405           
=======================================
  Hits         1853     1853           
  Misses          2        2           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orbeckst
Copy link
Member

orbeckst commented Jan 8, 2024

Why is py 3.12 installation failing?

@orbeckst
Copy link
Member

orbeckst commented Jan 8, 2024

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently fails Py 3.12 CI: apparently it cannot find pymbar.

We can't really release it until this is fixed.

@xiki-tempula
Copy link
Collaborator Author

@orbeckst
Ok, I guess we have to remove the support for python 3.12. I used to have this problem with python 3.12 before with mamba-org/provision-with-micromamba@main.
Then I had a look and found mamba-org/provision-with-micromamba@main to be deprecated, so I switch to mamba-org/setup-micromamba@main, the problem kind of goes away.
Then in this PR, I found that mamba-org/setup-micromamba@main tells me that extra-specs is deprecated and one should use create-args instead, so I switch to create-args and the python 3.12 problem goes back.

Now I had a more close look and it seems that there is no python 3.12 version for JAX, which is a dependency for pymbar.

The reason that mamba-org/setup-micromamba@main initially fixed the problem is because extra-specs is not a keyword for mamba-org/setup-micromamba@main so all of them are using python 3.11 instead of the specified python version.

@orbeckst
Copy link
Member

orbeckst commented Mar 23, 2024

Are these failures related to versioneer? https://github.com/alchemistry/alchemlyb/actions/runs/8396562936/job/22998193364?pr=346#step:3:595

 × python setup.py egg_info did not run successfully.
    │ exit code: 1
    ╰─> [18 lines of output]
        /tmp/pip-install-s_1hwqpj/alchemtest_0bb9d0ce4266426896888512ca32b04c/versioneer.py:421: SyntaxWarning: invalid escape sequence '\s'
          LONG_VERSION_PY['git'] = '''
        Traceback (most recent call last):
          File "<string>", line 2, in <module>
          File "<pip-setuptools-caller>", line 34, in <module>
          File "/tmp/pip-install-s_1hwqpj/alchemtest_0bb9d0ce4266426896888512ca32b04c/setup.py", line 15, in <module>
            version=versioneer.get_version(),
                    ^^^^^^^^^^^^^^^^^^^^^^^^
          File "/tmp/pip-install-s_1hwqpj/alchemtest_0bb9d0ce4266426896888512ca32b04c/versioneer.py", line 1480, in get_version
            return get_versions()["version"]

@xiki-tempula
Copy link
Collaborator Author

@orbeckst Yes, I'm fixing that now. I think it might be good for alchemtest to adopt the MolSSI cookiecutter then we could merge those fixed from them easily.

@orbeckst
Copy link
Member

closing and reopening, now that alchemtest has been update alchemistry/alchemtest#93

@orbeckst orbeckst closed this Mar 30, 2024
@orbeckst orbeckst reopened this Mar 30, 2024
@orbeckst orbeckst mentioned this pull request Mar 30, 2024
@xiki-tempula
Copy link
Collaborator Author

@orbeckst I think we could do the release before the doc PR as the doc will not affect the release.
I have deployed to test pypi and tested it locally which is fine.

@orbeckst
Copy link
Member

orbeckst commented Apr 6, 2024

Thank you @xiki-tempula ! Looking all good, go ahead 🚀 !

@xiki-tempula xiki-tempula merged commit eae82d8 into master Apr 6, 2024
12 checks passed
@xiki-tempula xiki-tempula deleted the 344-220-release branch April 6, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.2.0 release
2 participants