-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.2.0 release #346
2.2.0 release #346
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #346 +/- ##
=======================================
Coverage 98.82% 98.82%
=======================================
Files 28 28
Lines 1875 1875
Branches 405 405
=======================================
Hits 1853 1853
Misses 2 2
Partials 20 20 ☔ View full report in Codecov by Sentry. |
Why is py 3.12 installation failing? |
Is pymbar not packaged for 3.12 - https://github.com/alchemistry/alchemlyb/actions/runs/7451751133/job/20274729913?pr=346#step:3:49 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently fails Py 3.12 CI: apparently it cannot find pymbar.
We can't really release it until this is fixed.
@orbeckst Now I had a more close look and it seems that there is no python 3.12 version for JAX, which is a dependency for pymbar. The reason that |
Are these failures related to versioneer? https://github.com/alchemistry/alchemlyb/actions/runs/8396562936/job/22998193364?pr=346#step:3:595
|
@orbeckst Yes, I'm fixing that now. I think it might be good for alchemtest to adopt the MolSSI cookiecutter then we could merge those fixed from them easily. |
closing and reopening, now that alchemtest has been update alchemistry/alchemtest#93 |
@orbeckst I think we could do the release before the doc PR as the doc will not affect the release. |
Thank you @xiki-tempula ! Looking all good, go ahead 🚀 ! |
I have uploaded to pip and test that it works fine.