Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voices don't work inside of event sequences #255

Closed
daveyarwood opened this issue Jul 29, 2016 · 3 comments
Closed

Voices don't work inside of event sequences #255

daveyarwood opened this issue Jul 29, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@daveyarwood
Copy link
Member

daveyarwood commented Jul 29, 2016

It is not currently possible to include a voice group within an event sequence, e.g.:

p> piano: [V1: c d e V2: e f g]*2
16-Jul-29 09:47:15 skeggox.local ERROR [alda.repl.core] - Invalid Alda syntax.

It would be nice to be able to do this, at least for instruments (e.g. guitar, piano) where you can play multiple voices at once, and it is idiomatic for a repeatable thing or "riff" to contain multiple voices.

Worth noting, it is possible to include voices inside of a variable definition, but it is buggy:

p> foo = V1: c d e V2: e f g

p> piano: foo*2
# foo plays ONCE :(

p> foo = V1: c d e V2: e f g V0:

p> piano: foo*2
# foo plays twice :)

The issue here seems to be that voice groups do not implicitly end at the end of a variable definition, which can cause unexpected behavior.

@elydpg
Copy link
Contributor

elydpg commented Jul 29, 2016

Worth mentioning that voices seem to work in event sequences if you close them: [V1: c d e f V2: e f g a V0:]*2 does not throw an error. Seems to suggest that these are very similar issues.

@daveyarwood
Copy link
Member Author

Aha - intriguing... strokes beard

@daveyarwood
Copy link
Member Author

Fixed in 1.0.0-rc50. Thanks @bbqbaron! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants