Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Disable viewer popper completely #329

Closed
marcauberer opened this issue Mar 17, 2024 · 7 comments · Fixed by #335
Closed

Feature request: Disable viewer popper completely #329

marcauberer opened this issue Mar 17, 2024 · 7 comments · Fixed by #335

Comments

@marcauberer
Copy link
Contributor

Hi,
first of all thank for the awesome library!
I have a feature request: I have the use case where the user clicks on a calendar event and gets redirected to a different view. Currently, I use the onEventClick callback to navigate to the new view and use this as a hack to get rid of the unwanted popper:

customViewer={(_event, close) => {
  setTimeout(function () {
    close();
  }, 50);
}}

This seems not very good to me and could lead to race conditions.

Could you introduce a property, say disableViewer: boolean that disables the viewer popper completely?

@aldabil21
Copy link
Owner

Hi

you can use disableViewer prop in next release

@marcauberer
Copy link
Contributor Author

Thanks!

@marcauberer
Copy link
Contributor Author

@aldabil21 Just tried it out. I have to mention one shortcoming: If the disableViewer option is set, the onEventClick callback does not fire. Could you fix that?

@slash-84
Copy link
Contributor

slash-84 commented Apr 3, 2024

@marcauberer try with version 2.8.4 that enables the use of onEventClick with disableViewer. #338

@marcauberer
Copy link
Contributor Author

Will do, thanks!

@marcauberer
Copy link
Contributor Author

@aldabil21 @slash-84 onEventClick works now, but the viewer is still showing when agenda view is active. Can you fix that as well?

@slash-84
Copy link
Contributor

slash-84 commented Apr 8, 2024

i created #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants