Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DamageCalculator.spell_hit_chance #19

Closed
julienp opened this issue Nov 3, 2010 · 1 comment
Closed

DamageCalculator.spell_hit_chance #19

julienp opened this issue Nov 3, 2010 · 1 comment

Comments

@julienp
Copy link
Contributor

julienp commented Nov 3, 2010

Noticed this while trying to add some unittests, there's a "stats" missing here: https://github.com/Aldriana/ShadowCraft-Engine/blob/master/calcs/init.py#L134, should be
hit_chance = 1 - max(self.BASE_SPELL_MISS_RATE - self.stats.get_spell_hit_from_rating(),0)

@Aldriana
Copy link
Owner

Aldriana commented Nov 3, 2010

Fixed.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julienp @Aldriana