Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the is_strong_bpsw_prp code correct? #423

Closed
haru-44 opened this issue Sep 4, 2023 · 2 comments
Closed

Is the is_strong_bpsw_prp code correct? #423

haru-44 opened this issue Sep 4, 2023 · 2 comments

Comments

@haru-44
Copy link

haru-44 commented Sep 4, 2023

The is_strong_bpsw_prp is described as follows

gmpy/src/gmpy_mpz_prp.c

Lines 1518 to 1521 in 016dc98

"is_strong_bpsw_prp(n, /) -> bool\n\n"
"Return `True` if n is a strong Baillie-Pomerance-Selfridge-Wagstaff\n"
"probable prime. A strong BPSW probable prime passes the `is_strong_prp()`\n"
"test with base and the `is_strong_selfridge_prp()` test.\n");

On the other hand, it calls GMPY_mpz_is_selfridge_prp as follows

result = GMPY_mpz_is_selfridge_prp(NULL, temp);

I think I should call GMPY_mpz_is_strongselfridge_prp, am I mistaken?

@casevh
Copy link
Collaborator

casevh commented Sep 5, 2023

You are correct. A fix has been committed. I will be release version 2.2.0a1 as soon as I can.

@casevh casevh closed this as completed Sep 5, 2023
@haru-44
Copy link
Author

haru-44 commented Sep 5, 2023

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants