Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming of File in VSCode results in "ghost" bookmarks #209

Closed
pwahlmueller opened this issue May 8, 2019 · 4 comments
Closed

Renaming of File in VSCode results in "ghost" bookmarks #209

pwahlmueller opened this issue May 8, 2019 · 4 comments
Assignees
Milestone

Comments

@pwahlmueller
Copy link

When you change the filename in VSCode, the bookmark is still on the old filename.
It should be changed, so the bookmark will mark the line in the new file.
It is also not possible to change the filename at the bookmark section.

@alefragnani
Copy link
Owner

Hi @pwahlmueller ,

This was a known issue (already reported in #80), but wasn’t priority at the time.

But, rename a file right from the side bar, on the other hand, wasn’t something that I intended to do 😬 . Please, fill another issue (Feature Request) for that.

Thanks for reporting

@alefragnani
Copy link
Owner

Should use onDidRenameFiles event, described in https://code.visualstudio.com/api/references/vscode-api#workspace

@alefragnani alefragnani added this to the 11.4.0 milestone Jun 16, 2020
@fade2gray
Copy link
Contributor

Just an FYI: When I encountered this problem, I managed to transfer the bookmarks to the renamed file by editing the file path using an SQLite database editor.

@alefragnani
Copy link
Owner

Hi @fade2gray ,

Yes, that's possible. I used to look (for debugging purposes) at the LocalStorage in the Developer Tools. Unfortunatelly VS Code team changed that to files in disk 😞 .

But for this fix, I'll have to handle the onDidRenameFiles event and update the bookmarks manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants