-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multilanguage. Added English and Russian language. #222
Conversation
Hi @Inter-Net-Pro , First of all, thanks for your PR 👍 (also in Bookmarks extension) . What about the messages that the extension displays, like |
I did not find a solution to put translations in a separate folder (this would be convenient for you as a developer). But I really want the extension to work in my own language. |
Having the commands translated is already a great addition. I asked about the messages because I remembered that when the VS Code team first released the internationalization support, it wasn't so easy to do. I will try to find additional info about it, and update the extension if necessary. Thanks |
Hi @Inter-Net-Pro , I'll merge your PR in the next release. Could you please give me the proper translations for this resources? "projectManager.commands.addToFavorites.title": "Add to Favorites",
"projectManager.commands.toggleProjectEnabled.title": "Disable Project",
"projectManager.commands.saveFirstProject.title": "Save your First Project", Thank you |
Here is translation:
I think that you need to add to the file README section translations into languages and indicate there that the extension can be translated into different languages and give the path to the original file in English (make a small instruction). Then users from China, India and others will see about this opportunity and will be able to make and add to the repository translations into their native languages. |
Hi @Inter-Net-Pro , Yes, it will have it in the future, but the first step is to add the basic/first translations 😄 I have to ask you these new resources because it has been added to the extension after you created the PR, and I didn’t want to use Google Translator or similar tools, on this first release. I’m not sure how to deal with new resources yet.
Thank you |
If in localization file for some language there is no translation for some value, then VSCode will take the value from the default file package.nls.json |
I will follow the changes in file package.nls.json and supplement translation into Russian through github. |
Thanks for your suggestion. I'll keep it noted 👍 The new release should be available in the weekend. Stay tuned |
To add a new language, need to create a file package.nls.{language}.json