-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release-finish merge is merging release-branch into develop instead of master onto develop #289
Comments
@pennajenna Seems same as #213. Can you elaborate what benefit does it bring? |
Yes, if you merge master into develop, the tag from master is on develop. The way it is now, develop doesn’t have the same tag
…Sent from my iPhone
On Apr 21, 2021, at 3:16 PM, Aleksandr Mashchenko ***@***.***> wrote:
@pennajenna Seems same as #213. Can you elaborate what benefit does it bring?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
#213 reasons are exactly the same as mine, having that tag on develop is a necessity for me
Jenna
…Sent from my iPhone
On Apr 21, 2021, at 4:20 PM, Jenna McCormick ***@***.***> wrote:
Yes, if you merge master into develop, the tag from master is on develop. The way it is now, develop doesn’t have the same tag
Sent from my iPhone
>> On Apr 21, 2021, at 3:16 PM, Aleksandr Mashchenko ***@***.***> wrote:
>>
>
> @pennajenna Seems same as #213. Can you elaborate what benefit does it bring?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or unsubscribe.
|
submitted a PR for this: #291 |
DUPLICATE of #213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
gitflow-maven-plugin/src/main/java/com/amashchenko/maven/plugin/gitflow/GitFlowReleaseFinishMojo.java
Line 308 in da562a0
When using this, the release-finish is merging release-branch onto master and tagging correctly. Then it merges release-branch onto develop. This doesn't allow for the tag to be on develop. Is there a reason for this?
The text was updated successfully, but these errors were encountered: