-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error in building angular2-adal #8
Comments
Same issue here doing a clean install on a windows box. |
I fixed it by adding "adal": "github:DefinitelyTyped/DefinitelyTyped/adal-angular/adal.d.ts#53347571e6f44ed9a961b569bb81893fde4789c1" to typings.json |
@negberts , could you please submit a pull request of your fix to help us? |
@negberts
|
Well, this fix did it for me in the example... (https://github.com/alenny/angular2-adal-example) As I try it in this solution I get the errors src\services\adal.service.ts(34,36): error TS2339: Property 'inject' does not exist on type '{ AuthenticationContext: AuthenticationContextStatic; Logging: Logging; }'. Which seem correct because they don't exist on the interface at https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/adal-angular/adal.d.ts Maybe a systemjs.config should be added like in the example? (I am also still figuring out how to do this whole Angular2 thing :)) |
Well, I am not allowed to publish my feature branch, but the error can be fixed by adding your own adal\index.d.ts to the src branch. I took the index.d.ts from the angular2-adal-example node_modules\angular2-adal\typings\adal path |
no worries, I already created a pull request over there... alenny/angular2-adal-example#3 |
@jvanderbiest why in example repo rather than this source repo? |
@liushuping well, we want the example to work as well don't we? :) This source repo can be fixed by adding the file from my previous comment, but as I mentioned, authorization prohibites me from creating a pull request in this repo |
If you use Typings: |
I have the same issue while trying to integrate it in angular-cli project. do you have solution for this scenario where typings is not part of the project and instead using @type of npm? |
I am having the same issue while trying to use @types/adal. It is only an issue on a Window machine though, my Mac works fine. Anybody got ideas? |
Do you have typings installed globally both on the windows and mac machines? And I'm getting the following issue: ERROR in ./ Do you have any idea how can I solve this? |
I cloned the whole repo, and had run the commands
but get below errors:
The text was updated successfully, but these errors were encountered: