You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this would reduce the LoC of the parameters module and make it easier to maintain / review when changes are needed.
In that case I can see us removing all the .rs files in the module and just calling the impl macro in the lib.rs file. Then, we could also move all the .params and .sum files to a subdirectory called params (or something)
We probably should write a macro which impls Parameters, which would be invoked like so:
impl_params!(AccountCommitmentParameters, "./account_commitment.checksum", 417868, "./account_commitment.params");
this would reduce the LoC of the parameters module and make it easier to maintain / review when changes are needed.
In that case I can see us removing all the
.rs
files in the module and just calling theimpl
macro in thelib.rs
file. Then, we could also move all the.params
and.sum
files to a subdirectory calledparams
(or something)Originally posted by @gakonst in https://github.com/AleoHQ/snarkOS/pull/184
The text was updated successfully, but these errors were encountered: