Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement macro to generate Parameters #185

Closed
howardwu opened this issue Jun 3, 2020 · 0 comments · Fixed by #207
Closed

Implement macro to generate Parameters #185

howardwu opened this issue Jun 3, 2020 · 0 comments · Fixed by #207

Comments

@howardwu
Copy link
Contributor

howardwu commented Jun 3, 2020

We probably should write a macro which impls Parameters, which would be invoked like so:

impl_params!(AccountCommitmentParameters, "./account_commitment.checksum", 417868, "./account_commitment.params");

this would reduce the LoC of the parameters module and make it easier to maintain / review when changes are needed.

In that case I can see us removing all the .rs files in the module and just calling the impl macro in the lib.rs file. Then, we could also move all the .params and .sum files to a subdirectory called params (or something)

Originally posted by @gakonst in https://github.com/AleoHQ/snarkOS/pull/184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant