Fix: Test launch a VM without building it locally #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleting the line with mksquashfs which was building the runtimes locally.
added 2 commits
April 4, 2024 17:07
Adding a test which create a VM without building it locally
Removing useless import logging inside the test of the online VM build
|
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
hoh
reviewed
Apr 5, 2024
Comment on lines
14
to
17
| async def test_create_execution(): | ||
| """ | ||
| Create a new VM execution and check that it starts properly. | ||
| """ |
There was a problem hiding this comment.
Suggested change
| async def test_create_execution(): | |
| """ | |
| Create a new VM execution and check that it starts properly. | |
| """ | |
| async def test_create_execution_from_network(): | |
| """ | |
| Create a new VM execution from the diagnostic VM and check that it starts properly. | |
| This will download the resources from the aleph.im network if they are not present locally. | |
| """ |
There was a problem hiding this comment.
Yes I like this suggestion, i'll make the changes!
Some tests have the same scope, the only difference is that one test build locally the other download from the network. Solution: Group these tests in the same file.
hoh
approved these changes
Apr 8, 2024
hoh
pushed a commit
that referenced
this pull request
Apr 9, 2024
This tests that a VM from the aleph.im network can be downloaded and launched. Co-authored-by: ajin <ajin@Aleph.ajin.virtualbox.org>
hoh
pushed a commit
that referenced
this pull request
Apr 9, 2024
This tests that a VM from the aleph.im network can be downloaded and launched. Co-authored-by: ajin <ajin@Aleph.ajin.virtualbox.org>
hoh
pushed a commit
that referenced
this pull request
Apr 10, 2024
This tests that a VM from the aleph.im network can be downloaded and launched. Co-authored-by: ajin <ajin@Aleph.ajin.virtualbox.org>
olethanh
pushed a commit
that referenced
this pull request
Apr 10, 2024
This tests that a VM from the aleph.im network can be downloaded and launched. Co-authored-by: ajin <ajin@Aleph.ajin.virtualbox.org>
Psycojoker
deleted the
587-fix-pytest-doesnt-launch-the-diagnostic-vm-from-the-network
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting the line with mksquashfs