-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Test launch a VM without building it locally #588
Merged
hoh
merged 4 commits into
hoh-test-create-vm
from
587-fix-pytest-doesnt-launch-the-diagnostic-vm-from-the-network
Apr 8, 2024
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
import asyncio | ||
|
||
import pytest | ||
from aleph_message.models import ItemHash | ||
|
||
from aleph.vm.conf import settings | ||
from aleph.vm.controllers.firecracker import AlephFirecrackerProgram | ||
from aleph.vm.models import VmExecution | ||
from aleph.vm.orchestrator import metrics | ||
from aleph.vm.storage import get_message | ||
|
||
|
||
@pytest.mark.asyncio | ||
async def test_create_execution(): | ||
""" | ||
Create a new VM execution and check that it starts properly. | ||
""" | ||
|
||
# Ensure that the settings are correct and required files present. | ||
settings.setup() | ||
settings.check() | ||
|
||
# The database is required for the metrics and is currently not optional. | ||
engine = metrics.setup_engine() | ||
await metrics.create_tables(engine) | ||
|
||
vm_hash = ItemHash("3fc0aa9569da840c43e7bd2033c3c580abb46b007527d6d20f2d4e98e867f7af") | ||
message = await get_message(ref=vm_hash) | ||
|
||
execution = VmExecution( | ||
vm_hash=vm_hash, | ||
message=message.content, | ||
original=message.content, | ||
snapshot_manager=None, | ||
systemd_manager=None, | ||
persistent=False, | ||
) | ||
|
||
# Downloading the resources required may take some time, limit it to 10 seconds | ||
await asyncio.wait_for(execution.prepare(), timeout=30) | ||
|
||
vm = execution.create(vm_id=3, tap_interface=None) | ||
# Test that the VM is created correctly. It is not started yet. | ||
assert isinstance(vm, AlephFirecrackerProgram) | ||
assert vm.vm_id == 3 | ||
|
||
await execution.start() | ||
await execution.stop() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I like this suggestion, i'll make the changes!