Multi inputs endpoint - add more flexibilty #1090
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we were limited to either all inputs having defined gas or none at all. This commit adds more flexibility, such as enabling one address to cover gas costs for others. First we keep the same exact computing of gas per input, so we could potentially reduce the selected gas as previously. But on the second phase, in `updateMissingFeeFromSelectedGas` we check how many is already paid by the addresses that defined some gas. There are now two cases: 1. The explicit gas doesn't cover the overall gas needed for the tx: The addresses that didn't defined some gas will share this missing gas 2. There is enough gas for the all tx, it means we can update the gas to 0 to addresses that didn't define a gas.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1090 +/- ##
==========================================
+ Coverage 92.38% 92.43% +0.04%
==========================================
Files 378 378
Lines 18695 18725 +30
Branches 2015 2026 +11
==========================================
+ Hits 17271 17308 +37
+ Misses 1424 1417 -7 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.