Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi inputs endpoint - add more flexibilty #1090

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    bcc903d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d1041d View commit details
    Browse the repository at this point in the history
  3. Allows some inputs with defined gas and other not

    Before, we were limited to either all inputs having defined gas or none at all.
    This commit adds more flexibility, such as enabling one address to cover gas costs
    for others.
    
    First we keep the same exact computing of gas per input, so we could potentially
    reduce the selected gas as previously.
    
    But on the second phase, in `updateMissingFeeFromSelectedGas`
    we check how many is already paid by the addresses that defined some gas.
    
    There are now two cases:
    1. The explicit gas doesn't cover the overall gas needed for the tx:
       The addresses that didn't defined some gas will share this missing
       gas
    2. There is enough gas for the all tx, it means we can update the gas
       to 0 to addresses that didn't define a gas.
    tdroxler committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    7416540 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Fix PR comments

    tdroxler committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    79857b1 View commit details
    Browse the repository at this point in the history
  2. Fix more PR comments

    tdroxler committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    04f6f62 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8538916 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Configuration menu
    Copy the full SHA
    53bc2bd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4b2ea06 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    99d91a6 View commit details
    Browse the repository at this point in the history