Call to DotNetChecker only returns "f" or "t" instead of "false" or "true"

[RayNewman]

Nice work, I looked around a good bit for a NSIS DotNet installer and this one seemed the most elegant.

However I had problems getting it to work. Looks like the call into DotNetChecker.dll is only pushing the 1st character of the return into $0. I changed the DotNetChecker.nsh to check for "f" instead of "false" to get it to work.
...
DotNetChecker::IsDotNet${FrameworkVersion}Installed
Pop $0
${If} $0 == "f"
...

[bveenvliet]

You are probably using Unicode NSIS and this has to do with comparing single byte value with the double byte characters getting returned.

[RayNewman]

Ahh, unicode vs ascii makes sense. I'm using NSIS 3.0a1. If I add "Unicode True" to my script then (${If} $0 == "false") evaluates properly and all is well. I could be confused but that means that DotNetChecker should only be used when your script is compiled as Unicode?

From: Brad Veenvliet [mailto:notifications@github.com]
Sent: Saturday, November 23, 2013 6:06 PM
To: ProjectHuman/NsisDotNetChecker
Cc: RayNewman
Subject: Re: [NsisDotNetChecker] Call to DotNetChecker only returns "f" or "t" instead of "false" or "true" (#4)

You are probably using Unicode NSIS and this has to do with comparing single byte value with the double byte characters getting returned.

—
Reply to this email directly or view it on GitHub #4 (comment) .Image removed by sender.