Fixed the endpoint message to use app.name to match the endpoint route #76
Conversation
CHANGELOG.md
Outdated
| @@ -5,6 +5,8 @@ | |||
| * [#71](https://github.com/alexa-js/alexa-app-server/pull/71), [#68](https://github.com/alexa-js/alexa-app-server/issues/68): Fixed log output containing multiple slashes - [@tejashah88](https://github.com/tejashah88). | |||
| * [#72](https://github.com/alexa-js/alexa-app-server/pull/72): Use `path.join` for constructing relative paths - [@dblock](https://github.com/dblock). | |||
| * [#74](https://github.com/alexa-js/alexa-app-server/pull/74): Added locale selector to test page - [@siedi](https://github.com/siedi). | |||
| * Changed endpoint message to use app name to match route | |||
There was a problem hiding this comment.
Would you be so kind to make this look similar to other lines? Everything is on the same line, there's a -, a period at the end, etc.
There was a problem hiding this comment.
Fixed the formatting and added the PR link.
| @@ -128,7 +128,7 @@ var appServer = function(config) { | |||
| postRequest: self.config.postRequest | |||
| }); | |||
|
|
|||
| var endpoint = path.posix.join(normalizedRoot, pkg.name); | |||
| var endpoint = path.posix.join(normalizedRoot, app.name); | |||
| self.log(" loaded app [" + pkg.name + "] at endpoint: " + endpoint); | |||
There was a problem hiding this comment.
If you feel motivated, you could write a test for this using sinon, like https://github.com/alexa-js/alexa-app/blob/b30997f1e2fce2302bf1b04e855b19837edf5e8f/test/test_alexa_integration_express.js#L51
There was a problem hiding this comment.
So I added the test, with a new entry in the "invalid_examples" folder, and added the assertion in the existing invalid examples test. I wasn't sure where it fit the best, so I'm happy to restructure if you think there's a better spot for it.
|
The test feels a bit contrived or at least misplaced. First, it lives inside a test suite that is ensuring that invalid apps are loaded, it should be a standalone check all by itself. Second, this is a perfectly valid app, no? Maybe it doesn't belong in |
|
Let me take the valid/invalid app back - I see how you wouldn't want the names to be the way they are setup, so I am cool with the app being where it is. Just split the test about the logger warn message from the tests that ensure invalid apps are loaded at all. |
|
Do you prefer the test to have its own file? Or just a new test in the "test-examples-server-app-loading-fail-checks" file? |
|
I don't have a strong preference. |
|
Looks good, merging. |
A minor thing, but something that stymied me for a while when I started using the package. The "loaded app at endpoiont" message is inaccurate if the package.json name and the name used in the Alexa app constructor are different. Changed the message to use the app name, which is where the endpoint actually is.
Happy to flip this as well, and change the router to use the package.json name.