Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the endpoint message to use app.name to match the endpoint route #76

Merged
merged 6 commits into from
Feb 20, 2017
Merged

Fixed the endpoint message to use app.name to match the endpoint route #76

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b9dc24
Changed endpoint message to use app name instead of package name
CP-zweiler Feb 16, 2017
7e922d1
Changed endpoint message to use app name instead of package name
CP-zweiler Feb 16, 2017
da18bcb
Merge branch 'master' of https://github.com/zweiler/alexa-app-server
CP-zweiler Feb 17, 2017
8bc43a8
Added test for endpoint message matching app name
CP-zweiler Feb 18, 2017
289501a
Corrected changelog message to match previous entries
CP-zweiler Feb 18, 2017
5732256
Splits out check for app name to separate test
CP-zweiler Feb 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* [#71](https://github.com/alexa-js/alexa-app-server/pull/71), [#68](https://github.com/alexa-js/alexa-app-server/issues/68): Fixed log output containing multiple slashes - [@tejashah88](https://github.com/tejashah88).
* [#72](https://github.com/alexa-js/alexa-app-server/pull/72): Use `path.join` for constructing relative paths - [@dblock](https://github.com/dblock).
* [#74](https://github.com/alexa-js/alexa-app-server/pull/74): Added locale selector to test page - [@siedi](https://github.com/siedi).
* Changed endpoint message to use app name to match route
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be so kind to make this look similar to other lines? Everything is on the same line, there's a -, a period at the end, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the formatting and added the PR link.

[@zweiler](https://github.com/zweiler)
* Your contribution here.

### 3.0.0 (February 6, 2017)
Expand Down
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ var appServer = function(config) {
postRequest: self.config.postRequest
});

var endpoint = path.posix.join(normalizedRoot, pkg.name);
var endpoint = path.posix.join(normalizedRoot, app.name);
self.log(" loaded app [" + pkg.name + "] at endpoint: " + endpoint);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel motivated, you could write a test for this using sinon, like https://github.com/alexa-js/alexa-app/blob/b30997f1e2fce2302bf1b04e855b19837edf5e8f/test/test_alexa_integration_express.js#L51

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I added the test, with a new entry in the "invalid_examples" folder, and added the assertion in the existing invalid examples test. I wasn't sure where it fit the best, so I'm happy to restructure if you think there's a better spot for it.

});

Expand Down