-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove node 0.12 from Travis-CI. #220
Conversation
Yes, please, do remove node 0.12 support if we can't run tests anymore. Also we do want a green build whatever that takes ;) |
a51ca44
to
9afa9b9
Compare
Working on it - seeing some odd errors so will set-up Travis against my fork and figure out what is going on. |
Dependencies for alexa-app no longer work on Node 0.12 so remove node 0.12 from test matrix. Run extra steps with Node 1 instead. Missing space. Update engine.
3273cb5
to
fecc629
Compare
Okay, seems to be working now - also updated min version in |
CHANGELOG.md
Outdated
@@ -4,6 +4,7 @@ | |||
|
|||
* [#219](https://github.com/alexa-js/alexa-app/pull/219): Preserve session when clearing non-existent attribute - [@adrianba](https://github.com/adrianba). | |||
* [#218](https://github.com/alexa-js/alexa-app/pull/218): Fix cert check test cases - [@adrianba](https://github.com/adrianba). | |||
* [#220](https://github.com/alexa-js/alexa-app/pull/220): Remove Node 0.12 from Travis-CI - [@adrianba](https://github.com/adrianba). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should say "No longer compatible with Node 0.12".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Thanks @adrianba. |
Dependencies for alexa-app no longer work on Node 0.12 so remove node 0.12 from test matrix. Run extra steps with Node 1 instead. Also updated engine version in
package.json
.