/alexa-app

Remove node 0.12 from Travis-CI. #220

Merged
merged 2 commits into from Apr 5, 2017

Conversation

Reviewers

@dblock dblock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@adrianba @tejashah88 @dblock
@adrianba
Contributor

adrianba commented Apr 4, 2017 • edited

Dependencies for alexa-app no longer work on Node 0.12 so remove node 0.12 from test matrix. Run extra steps with Node 1 instead. Also updated engine version in package.json.
@tejashah88
Member

tejashah88 commented Apr 4, 2017

@dblock @adrianba Since we are removing testing support for node v0.12, would it make sense to just drop node v0.12 support for this library entirely?
@dblock
Collaborator

dblock commented Apr 5, 2017

Yes, please, do remove node 0.12 support if we can't run tests anymore. Also we do want a green build whatever that takes ;)
@adrianba
Contributor

adrianba commented Apr 5, 2017

Working on it - seeing some odd errors so will set-up Travis against my fork and figure out what is going on.
@adrianba adrianba Remove node 0.12 from Travis-CI. 
Dependencies for alexa-app no longer work on Node 0.12 so remove node 0.12 from test matrix. Run extra steps with Node 1 instead.

Missing space.

Update engine.

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 99.405%
Details
fecc629

adrianba referenced this pull request Apr 5, 2017

Merged

Fix cert check test cases. #218

@adrianba
Contributor

adrianba commented Apr 5, 2017

Okay, seems to be working now - also updated min version in package.json.
CHANGELOG.md
@@ -4,6 +4,7 @@
* [#219](https://github.com/alexa-js/alexa-app/pull/219): Preserve session when clearing non-existent attribute - [@adrianba](https://github.com/adrianba).
* [#218](https://github.com/alexa-js/alexa-app/pull/218): Fix cert check test cases - [@adrianba](https://github.com/adrianba).
+* [#220](https://github.com/alexa-js/alexa-app/pull/220): Remove Node 0.12 from Travis-CI - [@adrianba](https://github.com/adrianba).
@dblock

dblock Apr 5, 2017

Collaborator

I think this should say "No longer compatible with Node 0.12".

@adrianba

adrianba Apr 5, 2017

Contributor

Done.

@adrianba adrianba Update CHANGELOG message for #220.

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 99.405%
Details
0b7ddc0

dblock merged commit dc97022 into alexa-js:master Apr 5, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.405%
Details
@dblock
Collaborator

dblock commented Apr 5, 2017

Thanks @adrianba.

adrianba deleted the adrianba:remove-node-0.12 branch Apr 5, 2017

This was referenced Apr 8, 2017

Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment