Remove node 0.12 from Travis-CI. #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, please, do remove node 0.12 support if we can't run tests anymore. Also we do want a green build whatever that takes ;) |
adrianba
force-pushed
the
remove-node-0.12
branch
from
a51ca44
to
9afa9b9
Compare
|
Working on it - seeing some odd errors so will set-up Travis against my fork and figure out what is going on. |
Dependencies for alexa-app no longer work on Node 0.12 so remove node 0.12 from test matrix. Run extra steps with Node 1 instead. Missing space. Update engine.
adrianba
force-pushed
the
remove-node-0.12
branch
from
3273cb5
to
fecc629
Compare
|
Okay, seems to be working now - also updated min version in |
dblock
reviewed
Apr 5, 2017
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| * [#219](https://github.com/alexa-js/alexa-app/pull/219): Preserve session when clearing non-existent attribute - [@adrianba](https://github.com/adrianba). | |||
| * [#218](https://github.com/alexa-js/alexa-app/pull/218): Fix cert check test cases - [@adrianba](https://github.com/adrianba). | |||
| * [#220](https://github.com/alexa-js/alexa-app/pull/220): Remove Node 0.12 from Travis-CI - [@adrianba](https://github.com/adrianba). | |||
There was a problem hiding this comment.
I think this should say "No longer compatible with Node 0.12".
|
Thanks @adrianba. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies for alexa-app no longer work on Node 0.12 so remove node 0.12 from test matrix. Run extra steps with Node 1 instead. Also updated engine version in
package.json.