feat(ask-sdk-core/util) Add new helper function to get user id #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
ShenChen93
reviewed
May 2, 2019
| @@ -43,7 +44,7 @@ describe('RequestEnvelopeUtils', () => { | |||
| templateVersion : '1.0', | |||
| markupVersion : '1.0', | |||
| }, | |||
| }; | |||
| };requestEnvelope.context.System.user.userId = 'mockUserId' | |||
There was a problem hiding this comment.
Could you please write this one in a new line?
There was a problem hiding this comment.
Thanks for the feedback!
I've fixed it :)
|
Hi @hideokamoto The code looks good. Before I merge it in, could you please modify the commit name to "feat: add getUserId util function", In order to fit conventional commits structure. Thanks, |
feat(docs) add getUserId into the docs fix(ask-sdk-core) lint error of getUserId fix[ask-sdk-core] make a new line to define the user id
hideokamoto
force-pushed
the
feature/utils/getUserId
branch
from
7260ebb
to
1d85349
Compare
|
I've rebased my commits. |
ShenChen93
approved these changes
May 6, 2019
|
Hi, @hideokamoto Thanks for the PR! Merging this in. It will be included in the next SDK release. Regards, |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can get user id from the SDK.
Description
Add the
getUserIdfunction into the utils.We can get the user id more easier.
Motivation and Context
Now we can get the requested user's device id by the SDK.
But we want to get the user id too.
Before
Our code will be too long line :(
After
It is the simplest way to get the user ID :)
Testing
To run unit test by gulp.
Screenshots (if appropriate)
Types of changes
Checklist
License