New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with PHP 8 #13

Closed

p5yk0 opened this issue Jan 3, 2023 · 1 comment

p5yk0 commented Jan 3, 2023 •

edited

Loading

Since PHP 8, sockets are not considered as resources anymore but object.

In Socket.php

if (!is_resource($this->socket)) {
   return false;
}

should become

if (!(is_resource($this->socket) || $this->socket instanceof \Socket)) {
   return false;
}

see https://php.watch/versions/8.0/sockets-sockets-addressinfo

The text was updated successfully, but these errors were encountered:

Author

p5yk0 commented Jan 3, 2023

I've just noticed that it'is a duplicate of issue #11.

p5yk0 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment