Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new release #41

Closed
CodeLongAndProsper90 opened this issue Sep 29, 2020 · 7 comments
Closed

Create a new release #41

CodeLongAndProsper90 opened this issue Sep 29, 2020 · 7 comments

Comments

@CodeLongAndProsper90
Copy link
Contributor

For the PKGBUILD, a new release is needed so that the tarball can be fetched, and the repo contains a bugfix allowing code to run, so, perhaps create a v3.0.1 bugfix release. Thanks!

@alexapostolu
Copy link
Owner

can I release it now?

@alexapostolu
Copy link
Owner

alexapostolu commented Sep 29, 2020

Hmm.. slight problem with the Makefile though. To use the make command, you have to be in the same directory as the Makefile, but I want the current directory to be outside the src folder so this would be the best option:

make -S src
./night source.night

Should we change the readme file to say that? Or should we have the Makefile outside the src folder? I prefer the latter since I think having the executable outside the src file would be better

@CodeLongAndProsper90
Copy link
Contributor Author

The best thing would be a soft link but Windows can’t handle that, perhaps just make a dummy Makefile?
For example

.PHONY: all
all:
make -S src 

@CodeLongAndProsper90
Copy link
Contributor Author

Sorry for formatting on mobile rn

@alexapostolu
Copy link
Owner

Well, im not really an expert in makefiles so im not sure. Would that be better than what we have now?

@CodeLongAndProsper90
Copy link
Contributor Author

I mean cd src && make clean all is pretty standard

@alexapostolu
Copy link
Owner

Sure i guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants