-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write a script to import template names from https://github.com/chriskempson/base16-builder #19
Comments
I can do this if you want. |
@aloisdg Yes please. Here is a sample output:
Note: I want the Also note: Ideally templates will have consistent names. The convention I'm using at the moment is: Thanks. If you have any questions, please don't hesitate to ask. |
What about folder who have more than one? I am thinking about Atom for example.
I dont mind breaking the original model if we keep an entry on the wiki about it. A kind of "How this project differs from the original". I think it is very important to let people switch smoothly from one to another. |
@aloisdg It shouldn't be that much different from the original. And yes, I agree, there should be a section in the documentation outlining the differences.
I noticed that the Atom package uses two files, too. I wonder if it's possible to combine them somehow...? Aside from that, I'm not sure what to do... yet 😛 |
For now, I have:
done with a small bash script: #!/bin/bash
url="https://github.com/chriskempson/base16-builder/tree/master/templates/"
for item in *; do
echo "- [ ] [$item]($url$item)"
done |
Why you dont want to keep folder? Can you at least keep the same name for now (i3 vs i3wm)? I can eqsily write a script to autochecked boxes if we keep the old name. |
Another output with file:
As you see, we are going to make some changes.
|
I would love to add a link for each to the author and link to file in the project and one line to the old project. |
Nice job. You're a bash wizard 😉
Because the original tool mandates that you specify a path: $ base16-builder -s schemes/gooey -t templates/rxvt-unicode/rxvt-unicode-dark.erb I think it's much more intuitive to specify names: $ base16-builder -s gooey -t rxvt-unicode-dark Getting rid of folders enables this.
Sure. I can manually rename the templates after. Remember:
I say yes. From what I can see, a lot of the templates in that folder can be turned into top-level templates if necessary.
Hm. Good question. For now let's just omit the flag e.g.
Becomes....
Becomes....
Sound good? |
I dont really like bash but its handy. ^^
As an user, you shouldnt care about how the file is named. You want the template thats all. We could imagine something like this: $ base16-builder -s gooey -t rxvt-unicode -l dark -p 256 with "-l, --luminosity" (mandatory field) and "-p,--palette" (optional field) If luminosity is not set (as an optional field), we could imagine generate both dark and light. We could imagine run What do you think? |
👍 👍 👍 I think that is really pleasant syntax. Give me some time to mull it over and gather some external input.
At the moment I am against writing files to the system. I would much rather write to That makes it impossible to generate two themes at once. I will add an option to generate all themes in the future if there's a demand. For now, I want to keep it simple. |
I agree. You can open a new issue for this with a flag "up-for-graps". Maybe someone will do it. So we can create a spec. The delimiter is '-' and the extension is '.nunjucks'
A valid name is:
or
One more thing to add to the wiki ;) |
Yes, exactly! As long as we stick to that specification, it should be feasible to implement this syntax:
|
Still against the use of folder? Because with the spec we could just see the template as the folder to open and the file will be dark-256.nunjucks. Basically your path to read would be |
This spec is now valid. The delimiter is '-' and the extension is '.nunjucks'
A valid name is:
or
|
Write a throwaway script that
Reads every template name from this folder
Generates a task list for every template name:
Once the script has finished running, we can create a new issue to track progress of #16.
The text was updated successfully, but these errors were encountered: