Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite Recursion browser tab crashes #115

Open
habeelmazhar opened this issue Aug 2, 2021 · 3 comments · May be fixed by #150
Open

Infinite Recursion browser tab crashes #115

habeelmazhar opened this issue Aug 2, 2021 · 3 comments · May be fixed by #150

Comments

@habeelmazhar
Copy link

habeelmazhar commented Aug 2, 2021

Any URL that ends with some characters like @ or $ crashes.
Codepen link with an example

Obviously codepen URL does not crash but you can see that the script execution gets stuck.

@zahassanyum
Copy link

zahassanyum commented Aug 2, 2021

Is this related to: #82?

@habeelmazhar

@habeelmazhar
Copy link
Author

@zahassanyum Yeah almost the same, but it's different in a way that encodeURI does not fix this issue

@lionel-rowe
Copy link

It's a Catastrophic Backtracking issue. It's not technically "infinite", it's just that execution time grows exponentially with the length of the path, such that https://example.com/abc@ validates in reasonable time but https://example.com/abcdefghijklmnopqrstuvwxyz123456789@ crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants