[pull] master from kubernetes-sigs:master #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This pr implements the second half of the ["Move cluster-specific code out of the manager" proposal][0]: Making it start all caches before other Runnables and not just the one of the main Cluster. [0]: https://github.com/kubernetes-sigs/controller-runtime/blob/66537ca5b7439b06f2f3b08901640f934834c9a1/designs/move-cluster-specific-code-out-of-manager.md#L131-L132
🐛 Prevent source.Channel from shutting down immediately
During debugging a weird issue with some tests failing if they were running too fast. In other words, calling Start() and Close() on a manager too fast throws an error where the informers haven't been able to sync, which then makes Start() fail with an error. In an effort to improve this behavior, tried to use Elected() to wait for leader election to start, which also waits for the cache. During some debugging, this issue happened again and upon digging a bit more it seems that the channel was closed before starting the runnables in some cases. This change reorders the close on cm.elected, which should fix the above issue. Signed-off-by: Vince Prignano <vincepri@vmware.com>
Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
✨ Manager: Start all caches before other Runnables
🐛 Manager.Elected() should beclosed after runnables are started
✨Fix context.TODO() in the example
🌱 fix DestWritter var name typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )