Fix --kubeconfig flag priority

[burtonr]

The kubeconfig flag on the app install command does not affect the actual kubernetes command execution. The kubernetes command is executed against the default kubeconfig file, not the one passed in via flags.

Expected Behaviour

Passing the kubeconfig flag on the app install command should use that kubeconfig file when installing the app.

Current Behaviour

The kubeconfig variable is only written out, but not utilized:
https://github.com/alexellis/k3sup/blob/master/pkg/cmd/openfaas_app.go#L42

Possible Solution

Since the kubernetes_exec.go file is also in the cmd package, it's possible for the kubectl and kubectlTask functions to look for changes on the flag to get that passed in value. Much the same as the above pasted code from one of the apps.

Steps to Reproduce (for bugs)

1. k3sup app install openfaas --kubeconfig any/path/to/file
2. Output will say something like: "Using kubeconfig {the path from above}"
3. Run kubectl get pods --all-namespaces --kubeconfig /same/path/above
4. Observe the app was not installed
5. Run kubectl get pods --all-namespaces (without the kubeconfig)
6. See the application was installed on the incorrect cluster

Context

I have several k8s cluster set up in various environments for testing. Swapping the config files, or env var is annoying, and really time consuming if I forget before I run the install command.

Your Environment

• What OS or type or VM are you using? Where is it hosted?
  Linux/ARM
  Desktop (microk8s), GCP, DigitalOcean, Raspberry Pi 3+
• Operating System and version (e.g. Linux, Windows, MacOS):
  Linux

[phumberdroz]

So looking at this issue it carries thru all app installs currently.

I would like to make following changes:

• use only the current kubectlTask and remove the kubectl function and add tests.
• change the helm3 function so that it returns the task as well and add tests

/cc @alexellis

[alexellis]

use only the current kubectlTask and remove the kubectl function and add tests.

This sounds good, please go ahead and raise the first PR for it.

change the helm3 function so that it returns the task as well and add tests

There is no helm3() function, which do you mean?

[phumberdroz]

helm3Upgrade

[alexellis]

When should we expect a PR @phumberdroz ? 😄

[phumberdroz]

Hopefully today @alexellis :)

[alexellis]

Please could someone suggest a simpler alternative fix?

[Kerwood]

Sooo... Is this going to be fixed or ?

[alexellis]

See my comment from a month ago. What specific issue are you running into? Some people don't set their KUBECONFIG variable correctly. If you do that, then you shouldn't need this flag.

[Kerwood]

My KUBECONFIG variable is set to ./kubeconfig but I figured that when setting the --kubeconfig paramenter, one could override which kubeconfig ark would use.

[alexellis]

You should never use ./, always use pwd to get the whole absolute path. Otherwise it won't work when you move out of the folder or another app does.