Fix Installer to create ark alias #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ALIAS var in get.sh was not being used. It was looking for ALIAS_NAME, so I have updated to that. This was tested with `sudo sh get.sh`. Alias was created correctly Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
|
I wonder if this is broken elsewhere too? faas-cli etc? |
|
faas-cli looks fine. it used ALIAS_NAME in the definition |
2 tasks
VariableExp0rt
pushed a commit
to VariableExp0rt/arkade
that referenced
this pull request
Jan 4, 2024
# This is the 1st commit message: Update README.md Signed-off-by: liam.baker <liam.baker@sage.com> # This is the commit message alexellis#2: address comments and remove dependency on go-git Signed-off-by: liam.baker <liam.baker@sage.com> # This is the commit message alexellis#3: Fix for regex for downloading Node.js Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
VariableExp0rt
pushed a commit
to VariableExp0rt/arkade
that referenced
this pull request
Jan 4, 2024
# This is the 1st commit message: Update README.md Signed-off-by: liam.baker <liam.baker@sage.com> # This is the commit message alexellis#2: address comments and remove dependency on go-git Signed-off-by: liam.baker <liam.baker@sage.com> # This is the commit message alexellis#3: Fix for regex for downloading Node.js Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com> # This is the commit message alexellis#4: Bump golang.org/x/crypto from 0.14.0 to 0.15.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.15.0. - [Commits](golang/crypto@v0.14.0...v0.15.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> # This is the commit message alexellis#5: Bump golang.org/x/mod from 0.13.0 to 0.14.0 Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.13.0 to 0.14.0. - [Commits](golang/mod@v0.13.0...v0.14.0) --- updated-dependencies: - dependency-name: golang.org/x/mod dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> # This is the commit message alexellis#6: Bump github.com/spf13/cobra from 1.7.0 to 1.8.0 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.7.0...v1.8.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> # This is the commit message alexellis#7: feat: add kwok to arkade get tools Signed-off-by: Czékus Máté <mate@picloud.hu> # This is the commit message alexellis#8: feat: add kwokctl to arkade get tools Signed-off-by: Czékus Máté <mate@picloud.hu> # This is the commit message alexellis#9: Update system go installation for new format The endpoint on go.dev now returns additional text after the version, \ntime. This change trims off the second half of the output. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
VariableExp0rt
pushed a commit
to VariableExp0rt/arkade
that referenced
this pull request
Jan 4, 2024
# This is the 1st commit message: Update README.md Signed-off-by: liam.baker <liam.baker@sage.com> # This is the commit message alexellis#2: address comments and remove dependency on go-git Signed-off-by: liam.baker <liam.baker@sage.com> # This is the commit message alexellis#3: Fix for regex for downloading Node.js Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com> # This is the commit message alexellis#4: Bump golang.org/x/crypto from 0.14.0 to 0.15.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.15.0. - [Commits](golang/crypto@v0.14.0...v0.15.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> # This is the commit message alexellis#5: Bump golang.org/x/mod from 0.13.0 to 0.14.0 Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.13.0 to 0.14.0. - [Commits](golang/mod@v0.13.0...v0.14.0) --- updated-dependencies: - dependency-name: golang.org/x/mod dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> # This is the commit message alexellis#6: Bump github.com/spf13/cobra from 1.7.0 to 1.8.0 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.7.0...v1.8.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> # This is the commit message alexellis#7: feat: add kwok to arkade get tools Signed-off-by: Czékus Máté <mate@picloud.hu> # This is the commit message alexellis#8: feat: add kwokctl to arkade get tools Signed-off-by: Czékus Máté <mate@picloud.hu> # This is the commit message alexellis#9: Update system go installation for new format The endpoint on go.dev now returns additional text after the version, \ntime. This change trims off the second half of the output. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com> # This is the commit message alexellis#10: Bump golang.org/x/crypto from 0.15.0 to 0.16.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.15.0 to 0.16.0. - [Commits](golang/crypto@v0.15.0...v0.16.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> # This is the commit message alexellis#11: Bump github.com/google/go-containerregistry from 0.16.1 to 0.17.0 Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.16.1 to 0.17.0. - [Release notes](https://github.com/google/go-containerregistry/releases) - [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml) - [Commits](google/go-containerregistry@v0.16.1...v0.17.0) --- updated-dependencies: - dependency-name: github.com/google/go-containerregistry dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> # This is the commit message alexellis#12: Add rgee/snowmachine for the festive period Signed-off-by: Richard Gee <richard@technologee.co.uk> # This is the commit message alexellis#13: Bump actions/setup-go from 4 to 5 Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> # This is the commit message alexellis#14: Update README.md Signed-off-by: Alex Ellis <alexellis2@gmail.com> # This is the commit message alexellis#15: Export LoadFrom Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
VariableExp0rt
pushed a commit
to VariableExp0rt/arkade
that referenced
this pull request
Jan 4, 2024
# This is the 1st commit message: Update README.md Signed-off-by: liam.baker <liam.baker@sage.com> # This is the commit message alexellis#2: address comments and remove dependency on go-git Signed-off-by: liam.baker <liam.baker@sage.com> # This is the commit message alexellis#3: Fix for regex for downloading Node.js Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com> # This is the commit message alexellis#4: Bump golang.org/x/crypto from 0.14.0 to 0.15.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.15.0. - [Commits](golang/crypto@v0.14.0...v0.15.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> # This is the commit message alexellis#5: Bump golang.org/x/mod from 0.13.0 to 0.14.0 Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.13.0 to 0.14.0. - [Commits](golang/mod@v0.13.0...v0.14.0) --- updated-dependencies: - dependency-name: golang.org/x/mod dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> # This is the commit message alexellis#6: Bump github.com/spf13/cobra from 1.7.0 to 1.8.0 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.7.0...v1.8.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> # This is the commit message alexellis#7: feat: add kwok to arkade get tools Signed-off-by: Czékus Máté <mate@picloud.hu> # This is the commit message alexellis#8: feat: add kwokctl to arkade get tools Signed-off-by: Czékus Máté <mate@picloud.hu> # This is the commit message alexellis#9: Update system go installation for new format The endpoint on go.dev now returns additional text after the version, \ntime. This change trims off the second half of the output. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com> # This is the commit message alexellis#10: Bump golang.org/x/crypto from 0.15.0 to 0.16.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.15.0 to 0.16.0. - [Commits](golang/crypto@v0.15.0...v0.16.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> # This is the commit message alexellis#11: Bump github.com/google/go-containerregistry from 0.16.1 to 0.17.0 Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.16.1 to 0.17.0. - [Release notes](https://github.com/google/go-containerregistry/releases) - [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml) - [Commits](google/go-containerregistry@v0.16.1...v0.17.0) --- updated-dependencies: - dependency-name: github.com/google/go-containerregistry dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> # This is the commit message alexellis#12: Add rgee/snowmachine for the festive period Signed-off-by: Richard Gee <richard@technologee.co.uk> # This is the commit message alexellis#13: Bump actions/setup-go from 4 to 5 Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> # This is the commit message alexellis#14: Update README.md Signed-off-by: Alex Ellis <alexellis2@gmail.com> # This is the commit message alexellis#15: Export LoadFrom Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com> # This is the commit message alexellis#16: Bump go.mod and vendor Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com> # This is the commit message alexellis#17: Fix issue with version flag for Helm charts The version was being specified in an invalid way in args for the helm command via a string with a space. This has been changed to use a slice. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com> # This is the commit message alexellis#18: Bump golang.org/x/crypto from 0.16.0 to 0.17.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.16.0 to 0.17.0. - [Commits](golang/crypto@v0.16.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> # This is the commit message alexellis#19: Move to Go 1.21 for builds and minimum version Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com> # This is the commit message alexellis#20: Limit builds for same SHA Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com> # This is the commit message alexellis#21: Use Go 1.21 for e2e checker Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ALIAS var in get.sh was not being used. It was looking for
ALIAS_NAME, so I have updated to that.
This was tested with
sudo sh get.sh.Alias was created correctly
Fixes #1
Signed-off-by: Alistair Hey alistair@heyal.co.uk