Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system install for GitLab's runner #908

Merged
merged 1 commit into from
May 18, 2023

Conversation

NikhilSharmaWe
Copy link
Contributor

@NikhilSharmaWe NikhilSharmaWe commented May 18, 2023

Description

This PR add new option for system install for installing gitlab-runner.

Motivation and Context

How Has This Been Tested?

I test it by running the command arkade system install gitlab-runner locally. This command downloads the gitlab binary file in the dir path specified by the --path flag.

> ./arkade system install gitlab-runner
Installing GitLab Runner to $HOME/gitlab-runner
Installing version: latest for: amd64
Downloading from: https://gitlab-runner-downloads.s3.amazonaws.com/latest/binaries/gitlab-runner-linux-amd64
57.62 MiB / 57.62 MiB [--------------------------------------------------------------------------------------------] 100.00%
Downloaded to: /tmp/gitlab-runner-linux-amd64
Binary file copied to: /home/nikhilsharmawe/gitlab-runner

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

Signed-off-by: Nikhil Sharma <nikhilsharma230303@gmail.com>
@alexellis
Copy link
Owner

Hey this is great thank you for doing it so quickly.

Could you download the Arm64 and AMD64 binaries and show using file that they have the correct architecture?

You can't use this script, but it may show you what I mean - https://github.com/alexellis/arkade/blob/master/hack/test-tool.sh

@NikhilSharmaWe
Copy link
Contributor Author

NikhilSharmaWe commented May 18, 2023

@alexellis
I have added a demo in the PR description regarding this.

@alexellis
Copy link
Owner

That demo looks great. Thank you for adding the variations and output from file

@alexellis alexellis merged commit b8c2f3b into alexellis:master May 18, 2023
@alexellis alexellis changed the title add system install for gitlab runner Add system install for GitLab's runner May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitLab's runner to arkade system install
2 participants