-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add messages option #125
Add messages option #125
Conversation
f30e9f9
to
8d8b480
Compare
In the YAML files perhaps Could we have an alias of |
Yes Alex your proposals are great I will add those. |
8d8b480
to
2857122
Compare
/set reviewer: rgee0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only part way through. Will pick up again later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Martin. Finally got around to finishing up the review. For the time being I've put aside that I don't particularly like message
as a command label.
Thank you @rgee0 I will refer your comments tomorrow. I am open to suggestions on naming the feature. I went with |
I think: Feature toggle and definition within YAML: custom_messages or just messages Does that work? I think it's what Martin landed on |
Using @martindekov if this is meant to be a separate feature then there's further rework required. If I ask how a user would use the |
You're right. I think this doesn't need to be a toggle, but the feature should be documented with the names as per above. |
You are correct again, I suggested "topic" as the command, but Martin chose "message" and I'm ok with that choice. |
What I might have seen that somewhere else not sure why I got message in my head I apologise I will swap that for sure. |
I will go with topic |
I preferred your suggestion of /message and /msg. Please can you keep that as it is? |
To clarify: #109 (comment) |
Adding messages option to the derek bot in order to apply tempaltes or boilerplate things that we write all the time. Signed-off-by: Martin Dekov (VMware) <mdekov@vmware.com>
2857122
to
edf97f0
Compare
Thank you @rgee0 for the extended review. I will need to test the change before it is good to go. If you have any more comments let me know. 💯 |
Also tested e2e on my repo I believe if there are no further commends this is good to go 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Merged 👍 thank you Martin |
Adding messages option to the derek bot in order
to apply tempaltes or boilerplate things that we write
all the time.
Signed-off-by: Martin Dekov (VMware) mdekov@vmware.com
Description
Extending the comments handler, by passing the derek config file (
.DEREK.yml
), in order to take themessages
field from it and pass it to the executing function which sends the message to the Issue.Motivation and Context
Closes #109
How Has This Been Tested?
Manually multi line literal value of the message:
Manually single line value of message:
Whole content of
.DEREK.yml
:Image is here
martindekov/derek:0.0.7
, in order to test augment your.DEREK.yml
file like pointed in the picture above and swap the images.Types of changes
Checklist:
git commit -s