Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] kubeconfig merge with wrong order #317

Closed
wants to merge 1 commit into from

Conversation

zzswang
Copy link

@zzswang zzswang commented Mar 18, 2021

issue

#316 (comment)

Description

  • merge kube config files in wrong order
  • reproduced with raw kubectl command

How Has This Been Tested?

  • k3sup install with 3 nodes
  • remove k3s
  • resetup with 3 nodes, now it works fine

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@derek
Copy link

derek bot commented Mar 18, 2021

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Mar 18, 2021
issue alexellis#316

Signed-off-by: zzswang <zzswang@36node.com>
@zzswang
Copy link
Author

zzswang commented May 8, 2021

@alexellis

Will we merge this pr recently?
Or I still need to do the merge manually.

@alexellis
Copy link
Owner

Hi @zzswang, I'll tend to prioritise issue that relate to a clearly defined problem. I still think this is a user error rather than something in k3sup, and don't understand the negative effects of changing this order.

If k3sup is something that creates value for you and saves you time, please consider becoming a GitHub sponsor so that I can continue to support users like yourself with their bespoke support requests.

I've commented on your issue. Can you clarify?

Alex

@zzswang
Copy link
Author

zzswang commented May 8, 2021

commented in the issue

#316 (comment)

@zzswang zzswang closed this Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants